Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PFW-1097 M600: Fix filament change behavior when print is paused #4408

Merged
merged 2 commits into from
Nov 16, 2023
Merged

PFW-1097 M600: Fix filament change behavior when print is paused #4408

merged 2 commits into from
Nov 16, 2023

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented Sep 24, 2023

Reimplementing PR 2390 #2390 from @wavexx ontop of latest MK3 branch with some minor additional changes

Tested on MK3S+ with MMU3.

Steps to test:

  1. Start print
  2. Pause print
  3. Wait for while
  4. Go to Tune -> Color change
  5. Cold nozzle should now be re-heated
  6. Filament is loaded successfully
  7. Nozzle target temperature is set to 0°C again since the print is still paused.
  8. Resume print => print resumes without issues

@gudnimg gudnimg added this to the FW 3.14.0 milestone Sep 24, 2023
@github-actions
Copy link

github-actions bot commented Sep 24, 2023 •
edited
Loading

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 80 0 246042 5634 7910 2558
MK3_MULTILANG 86 0 245336 5643 8616 2549

@gudnimg gudnimg mentioned this pull request Sep 24, 2023
Closed
@gudnimg gudnimg changed the title Fix filament change behavior when print is paused PFW-1097 Fix filament change behavior when print is paused Sep 24, 2023
@gudnimg gudnimg changed the title PFW-1097 Fix filament change behavior when print is paused PFW-1097 M600: Fix filament change behavior when print is paused Oct 1, 2023
@gudnimg
Copy link
Collaborator Author

gudnimg commented Oct 3, 2023

I wonder if this fixes #4379

@3d-gussner do you have PrusaLink setup?

@gudnimg
Copy link
Collaborator Author

gudnimg commented Oct 15, 2023 •
edited
Loading

Rebased to sync with MK3 branch (105 commits)

@gudnimg gudnimg linked an issue Oct 28, 2023 that may be closed by this pull request
[BUG] Nozzle set temperature remains at 0 during filament change when pausing print from PrusaLink #4379
Closed
3d-gussner
3d-gussner approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@3d-gussner 3d-gussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MK404 and works as advertised.

@gudnimg gudnimg merged commit 4922bcd into prusa3d:MK3 Nov 16, 2023
5 checks passed
@gudnimg gudnimg deleted the PR2390 branch November 16, 2023 07:37
@3d-gussner 3d-gussner removed their assignment Nov 29, 2023
@3d-gussner 3d-gussner mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3d-gussner 3d-gussner 3d-gussner approved these changes

@wavexx wavexx Awaiting requested review from wavexx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
FW 3.14.0
Development

Successfully merging this pull request may close these issues.

[BUG] Nozzle set temperature remains at 0 during filament change when pausing print from PrusaLink
2 participants
@gudnimg @3d-gussner