fix(strapi): Make volume optional

Makes the volume optional and fixes some typos.
protofy · Apr 17, 2024 · da7f4c4 · da7f4c4
1 parent 6c35e6c
commit da7f4c4
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 8 deletions.
diff --git a/charts/strapi/Chart.yaml b/charts/strapi/Chart.yaml
@@ -13,7 +13,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.1
+version: 0.1.2
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.

diff --git a/charts/strapi/templates/deployment.yaml b/charts/strapi/templates/deployment.yaml
@@ -139,7 +139,7 @@ spec:
                 secretKeyRef:
                   name: strapi-secrets 
                   key: init.admin.email
-            - NAME: S3_ENABLED
+            - name: S3_ENABLED
               value: {{ .Values.s3.enabled }}
             - name: S3_ENDPOINT
               valueFrom:
@@ -161,34 +161,36 @@ spec:
                 secretKeyRef:
                   name: strapi-secrets 
                   key: s3.secret.key
-            - NAME: APP_KEYS
+            - name: APP_KEYS
               valueFrom:
                 secretKeyRef:
                   name: strapi-secrets 
                   key: app_keys
-            - NAME: JWT_SECRET
+            - name: JWT_SECRET
               valueFrom:
                 secretKeyRef:
                   name: strapi-secrets 
                   key: jwt_secret
-            - NAME: ADMIN_JWT_SECRET
+            - name: ADMIN_JWT_SECRET
               valueFrom:
                 secretKeyRef:
                   name: strapi-secrets 
                   key: admin_jwt_secret
-            - NAME: API_TOKEN_SALT
+            - name: API_TOKEN_SALT
               valueFrom:
                 secretKeyRef:
                   name: strapi-secrets 
                   key: api_token_salt
-            - NAME: TRANSFER_TOKEN_SALT
+            - name: TRANSFER_TOKEN_SALT
               valueFrom:
                 secretKeyRef:
                   name: strapi-secrets 
                   key: transfer_token_salt
           volumeMounts:
+            {{- if .Values.persistence.enabled }}
             - name: strapi-data
               mountPath: /opt/public/uploads
+            {{- end }}
           ports:
             - name: http
               containerPort: {{ .Values.service.port }}

diff --git a/charts/strapi/templates/volume.yaml b/charts/strapi/templates/volume.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.persistence.enabled }}
 apiVersion: v1
 kind: PersistentVolumeClaim
 metadata:
@@ -10,4 +11,4 @@ spec:
       storage: {{ .Values.persistence.size }}
   storageClassName: {{ .Values.persistence.storageClass }}
   volumeName: {{ default (include "strapi.fullname" .) }}
-
+{{- end }}
diff --git a/charts/strapi/values.yaml b/charts/strapi/values.yaml
@@ -28,6 +28,8 @@ podAnnotations: {}
 persistence:
   enabled: false
   existingClaim: ""
+  storageClass: gp2
+  storage: 2Gi
 podSecurityContext: {}
 # fsGroup: 2000