#4 support authentication for listing labels & milestones

Fixes #4

client/github/github_client.go

@@ -1,5 +1,22 @@
 package github
 
-import "github.com/google/go-github/v67/github"
+import (
+	"github.com/google/go-github/v67/github"
+	"propromo/cmdutils"
+)
 
-var client = github.NewClient(nil)
+func NewGitHubClient(token string) *github.Client {
+	return github.NewClient(nil).WithAuthToken(token)
+}
+
+func NewGitHubClientWithOptionalToken(token *string) *github.Client {
+	client := github.NewClient(nil)
+	if token != nil {
+		nonNilToken := *token
+		if nonNilToken == "" {
+			cmdutils.Logger.Fatal("Empty token passed. Either supply `nil` or a valid GitHub PAT.")
+		}
+		client = client.WithAuthToken(nonNilToken)
+	}
+	return client
+}

client/github/github_labels.go

@@ -6,16 +6,17 @@ import (
 	"propromo/utils"
 )
 
-func ListGitHubLabels(repo utils.GitRepo) ([]*github.Label, error) {
+func ListGitHubLabels(token *string, repo utils.GitRepo) ([]*github.Label, error) {
 	ctx := context.Background()
+	client := NewGitHubClientWithOptionalToken(token)
 
 	labels, _, err := client.Issues.ListLabels(ctx, repo.Owner, repo.Repository, nil)
 	return labels, err
 }
 
 func CreateGitHubLabel(token string, repo utils.GitRepo, label *github.Label) (*github.Label, error) {
 	ctx := context.Background()
-	client := github.NewClient(nil).WithAuthToken(token)
+	client := NewGitHubClient(token)
 
 	label, _, err := client.Issues.CreateLabel(ctx, repo.Owner, repo.Repository, label)
 	return label, err

client/github/github_milestones.go

@@ -6,16 +6,17 @@ import (
 	"propromo/utils"
 )
 
-func ListGitHubMilestones(repo utils.GitRepo) ([]*github.Milestone, error) {
+func ListGitHubMilestones(token *string, repo utils.GitRepo) ([]*github.Milestone, error) {
 	ctx := context.Background()
+	client := NewGitHubClientWithOptionalToken(token)
 
 	milestones, _, err := client.Issues.ListMilestones(ctx, repo.Owner, repo.Repository, nil)
 	return milestones, err
 }
 
 func CreateGitHubMilestone(token string, repo utils.GitRepo, milestone *github.Milestone) (*github.Milestone, error) {
 	ctx := context.Background()
-	client := github.NewClient(nil).WithAuthToken(token)
+	client := NewGitHubClient(token)
 
 	milestones, _, err := client.Issues.CreateMilestone(ctx, repo.Owner, repo.Repository, milestone)
 	return milestones, err

cmd/github/sync_labels.go

@@ -14,12 +14,14 @@ var labelsCmd = &cobra.Command{
 	Use:   "labels",
 	Short: "Sync labels from one repo to others",
 	Run: func(command *cobra.Command, args []string) {
+		token := getToken()
+
 		fmt.Println("Syncing from", source, "to", targets)
 
 		sourceRepo, err := utils.ParseGitRepo(source)
 		cobra.CheckErr(err)
 
-		labels, err := github.ListGitHubLabels(sourceRepo)
+		labels, err := github.ListGitHubLabels(&token, sourceRepo)
 		cobra.CheckErr(err)
 		if len(labels) == 0 {
 			cmdutils.Logger.Warn("No Labels in source repo found, aborting sync.")
@@ -33,7 +35,6 @@ var labelsCmd = &cobra.Command{
 			repos[i] = repo
 		}
 
-		token := getToken()
 		for _, repo := range repos {
 			for _, label := range labels {
 				_, err := github.CreateGitHubLabel(token, repo, &githubmodel.Label{

cmd/github/sync_milestones.go

@@ -14,12 +14,13 @@ var milestonesCmd = &cobra.Command{
 	Use:   "milestones",
 	Short: "Sync milestones from one repo to others",
 	Run: func(command *cobra.Command, args []string) {
+		token := getToken()
 		fmt.Println("Syncing from", source, "to", targets)
 
 		sourceRepo, err := utils.ParseGitRepo(source)
 		cobra.CheckErr(err)
 
-		milestones, err := github.ListGitHubMilestones(sourceRepo)
+		milestones, err := github.ListGitHubMilestones(&token, sourceRepo)
 		cobra.CheckErr(err)
 		if len(milestones) == 0 {
 			cmdutils.Logger.Warn("No Milestones in source repo found, aborting sync.")
@@ -33,7 +34,6 @@ var milestonesCmd = &cobra.Command{
 			repos[i] = repo
 		}
 
-		token := getToken()
 		for _, repo := range repos {
 			for _, milestone := range milestones {
 				_, err := github.CreateGitHubMilestone(token, repo, &githubmodel.Milestone{