[prometheus-pushgateway] Add 'release' label to prometheus-pushgateway service monitor #4369
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'release' label is required for integrating with kube-prometheus-stack
What this PR does / why we need it
Adds 'release' label to prometheus-pushgateway ServiceMonitor.
This label is used by prometheus from kube-prometheus-stack for collecting metrics.
I cannot use {{ .Release.Name }} as value in values.yaml. So I've add it to template.
Also, I don't understand why kube-prometheus-stack uses 'release' label, but not 'app.kubernetes.io/instance' label.
But I am not good in k8s.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter]
)