-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump AppWrapper to 1.0.0 #652
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Perhaps the Makefile can also be updated to use Kueue v0.10.0 |
I'm getting this error on attempt to create AppWrapper, in the CFO logs:
|
115562f
to
1c744d3
Compare
I rebased to pick up refreshed go.mod from #655. Building the binary locally is fine. We'll need to update the go-toolset image in the Dockerfile to something that supports go 1.23 before this can be merged. Otherwise I think it should be ready to go. |
+ Update to Kueue 0.10 + Remove deprecated kube-rbac-proxy + Refactor workload controller to prepare to upstream to Kueue
Should be good to go when you are ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!!
Kueue upgrade has been made. We will sync changes to RHOAI as soon as this PR is merged and we sync to downstream as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I have tested integration with Kueue v0.10.1 and this version of the CFO.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Combines go.mod changes of #651 with the Makefile change to pick up the CRD.