Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump AppWrapper to 1.0.0 #652

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dgrove-oss
Copy link
Collaborator

  • Update to Kueue 0.10
  • Remove deprecated kube-rbac-proxy
  • Refactor workload controller to prepare to upstream to Kueue

Combines go.mod changes of #651 with the Makefile change to pick up the CRD.

@openshift-ci openshift-ci bot requested review from astefanutti and dimakis January 16, 2025 18:55
Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign christianzaccaria for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChristianZaccaria
Copy link
Contributor

Perhaps the Makefile can also be updated to use Kueue v0.10.0

@ChristianZaccaria
Copy link
Contributor

I'm getting this error on attempt to create AppWrapper, in the CFO logs:

2025-01-16T20:51:21Z ERROR Unhandled Error {"logger": "UnhandledError", "error": "pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:243: Failed to watch *v1.Namespace: failed to list *v1.Namespace: namespaces is forbidden: User "system:serviceaccount:redhat-ods-applications:codeflare-operator-controller-manager" cannot list resource "namespaces" in API group "" at the cluster scope"}

@dgrove-oss dgrove-oss force-pushed the awbump branch 2 times, most recently from 115562f to 1c744d3 Compare January 22, 2025 14:02
@dgrove-oss
Copy link
Collaborator Author

I rebased to pick up refreshed go.mod from #655. Building the binary locally is fine.

We'll need to update the go-toolset image in the Dockerfile to something that supports go 1.23 before this can be merged. Otherwise I think it should be ready to go.

@dgrove-oss dgrove-oss mentioned this pull request Jan 22, 2025
4 tasks
+ Update to Kueue 0.10
+ Remove deprecated kube-rbac-proxy
+ Refactor workload controller to prepare to upstream to Kueue
Dockerfile Outdated Show resolved Hide resolved
@dgrove-oss
Copy link
Collaborator Author

Should be good to go when you are ready to merge.

Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!!

Kueue upgrade has been made. We will sync changes to RHOAI as soon as this PR is merged and we sync to downstream as well.

Copy link
Contributor

@Ygnas Ygnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I have tested integration with Kueue v0.10.1 and this version of the CFO.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants