Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated update step for component metadata file in workflow #650

Merged

Conversation

oksanabaza
Copy link
Contributor

Issue link

https://issues.redhat.com/browse/RHOAIENG-16074

What changes have been made

Added automated update step for component metadata file in workflow

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

steps:
- name: Generate component_metadata.yaml
run: |
cat <<EOL > config/component_metadata.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fail to see how this can update the files in the corresponding repositories. Am I missing it?

Also it does not cover the training operator right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently no way to fully automate updating the files in the corresponding repositories. The version of the component can only be updated during the rebase/sync process. The purpose of this PR is to autogenerate the component_metadata file as part of the release process, ensuring all versions are accurately captured from the input fields before the release.

I haven’t included the training operator because it is not part of our release parameters

@sutaakar
Copy link
Contributor

I think that the metadata upgrade should be part of component release/upgrade workflow, as that is the point when component is changed.
For Ray/Training operator/Kueue the release/upgrade is independent action from CodeFlare release. So I think that as part of CodeFlare release we can upgrade just version of CFO(AppWrapper?)/SDK.

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@astefanutti
Copy link
Contributor

/lgtm

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@sutaakar @astefanutti I think we can merge this now

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9519938 into project-codeflare:main Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants