Remove cluster objects dependency from platform #37124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37124: Size comparison from b02badf to 23b5bad Full report (45 builds for cc13x4_26x4, cc32xx, cyw30739, linux, psoc6, qpg, stm32, tizen)
|
github-actions
bot
added
esp32
linux
nrf connect
zephyr
telink
tizen
|
PR #37124: Size comparison from b02badf to 7463613 Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37124: Size comparison from b02badf to 031d187 Full report (5 builds for cc32xx, stm32, tizen)
|
|
PR #37124: Size comparison from b02badf to 4340aa6 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, telink, tizen)
|
|
PR #37124: Size comparison from b02badf to 82c9ef9 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Jan 20, 2025
tehampson
approved these changes
Jan 20, 2025
ksperling-apple
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster objects has a massive dependency: https://github.com/project-chip/connectedhomeip/blob/master/src/app/common/BUILD.gn#L48
This prevents platform to be considered very low level, e.g #36962 has trouble adding dependencies due to circularity if inet tries to depend on platform (which seems reasonable).
Instead I had to add some dependencies on
app:app_config(which seems much smaller), someutil:types(which seem not ideal, should be cleaned up) and actual cluster-objects when they were used transitively.Needed to work around a layering breakage from #36939 . Created #37126 to fix that properly.
Testing
Locally tested a build of linux tests (that enforce platform build).
Locally tested a qpg light build (to assume a more complex app/platform) and fixed several deps as a result. We still seem to have quite a few
utiltype dependencies that should be fixed eventually.Using CI to validate that the rest of the platforms build OK (and what dependencies we have to remove if not).