adhoc fix for 6uwi for mmCIF #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoes
requested changes
Nov 8, 2023
|
But isn't this going to produce warnings in normal cases - whenever you have a non-interger altloc that isn't requested? |
Good point. We still want to filter them. Thanks |
|
And what if a file has altloc 'A' and altloc '1'? Then this will merge them. |
|
ok, the altloc masking works for CIF too It looks more complicated to set it for PDB where things seem to be assigned dynamically through the loop. |
|
It looks like this breaks the multi-model case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially helps with #1790
We still need a fix for MMTF