Older PG compat

[Xowap]

Closes #1305

Successful PR Checklist:

• Tests
  • (not applicable?)
• Documentation
  • (not applicable?)

PR label(s):

• PR type: breaking 💥 Contains breaking changes
• PR type: feature ⭐️ Contains new features
• PR type: bugfix 🕵️ Contains bug fix
• PR type: miscellaneous 👾 Contains misc changes
• PR type: dependencies 🤖 Contains only dependencies updates
• PR type: documentation 📚 Contains documentation updates

[github-actions]

Coverage report

This PR does not seem to contain any modification to coverable code.

[medihack]

Hi @Xowap. Thanks a lot for fixing this! We should also test older Postgresql versions during CI. I already added a PR draft for that (#1307). If you like, add the changes in the ci.yml to your PR and extend the supported versions of PostgreSQL (matrix.postgresql-version). We can try everything >= 13 (https://www.postgresql.org/support/versioning/).

[Xowap]

Makes much sense, adding it

[medihack]

LGTM. @ewjoachim Ok for you, too?
I will add a note about the supported PostgreSQL versions to the documentation. I have to adjust the supported Python versions there anyway.

[ewjoachim]

I'm a bit weary of adding so many tests. What about changing the existing python matrix so that at the same time as we test old python versions, we test old postgres too ?

[medihack]

My first version exactly did this, but I did not like it. I don't want to run coverage or upload artifacts. Of course, one can do this conditionally, but the job becomes more complicated. Also, the matrix itself becomes more complex as we want to test every Python version, but not every Python version against every database version. So, overall, I find a separate job more clear.
But I can implement it in my other PR (#1307) how it would look like.

[medihack]

So it would look something like this then. Do you think it's better? Or do you have something else in mind?
The --cov quite matters (running the whole test suite on my Laptop 47s vs 55s).

[medihack]

@Xowap I understood ewjoachim wrong, but his suggestion makes total sense now. Would you mind adapting the CI code to something like this: https://github.com/procrastinate-org/procrastinate/pull/1307/files
Sorry for the extra work and that I didn't think of it myself 🤦.

[medihack]

@Xowap I had some time left and quickly changed it 🙂.

[medihack]

@Xowap Thanks a lot for the contribution! I will create a new fix release later.

[Xowap]

Thanks for making contributing a nice experience!

Waiting eagerly to revert my pyproject.toml back to sanity 🤓

[ewjoachim]

It was a pleasure to welcome your first Procrastinate contribution :) See you around !