Update pyproject.toml metadata format for poetry 2.0 (closer to PEP 621) #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR type: dependencies 🤖
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
medihack
reviewed
Jan 19, 2025
| @@ -2,49 +2,51 @@ | |||
| requires = ["poetry-core", "poetry-dynamic-versioning"] | |||
| build-backend = "poetry_dynamic_versioning.backend" | |||
|
|
|||
| [tool.poetry] | |||
| [project] | |||
| name = "procrastinate" | |||
| version = "0.0.0" | |||
There was a problem hiding this comment.
I think we can use dynamic = ["version"].
There was a problem hiding this comment.
Hm, I had made that change, I wonder why it was undone...
There was a problem hiding this comment.
Hm, because Poetry complains if we do that. It will be a change for when we switch to uv.
There was a problem hiding this comment.
Ah yes, the official recommendation from poetry check was to use
[project]
dynamic = ["version"]
[tool.poetry]
version = "0.0.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Successful PR Checklist:
PR label(s):