-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve devcontainer setup #1277
Conversation
context: .. | ||
dockerfile: .devcontainer/Dockerfile | ||
volumes: | ||
- ../..:/workspaces:cached |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder a bit why they mount the parent directory of the project in the template, but I kept it that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Wonder if it works with github.dev too.
Hm, I tested it only locally and unfortunately there is an import error when I try to run the tests in Github Codespaces. I mark the PR as a draft and figure it out (why can't things just work sometimes out on their own ;-)) |
Ah, ignore my last message. Everything works fine in Github Codespaces, too. Just tried out the wrong branch 🙄. So, yes it works as expected. |
Wow so that means you can get on the repo, hit |
Not quite. The "." (github.dev) is a completely free in-browser editor only. You can still change code, commit and push, but you can't run a devcontainer or a terminal in it. |
Improves the devcontainer setup by using a docker-compose file to spin up the database.
Maybe we can, at some point, combine both our docker-compose.yml files (maybe even the Dockerfile).
Successful PR Checklist:
PR label(s):