Fix: set stroke and fill properly in PFont.getShape #899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
PFont.getShape
returns an instance ofPShape
which renders nothing.This is because fill and storke are not properly set in the construction of the shape.
The commit fixes the issue by calling
PShape.noStroke()
andPShape.fill(0)
at the begining of the construction.Test code:
winjs-symbols.ttf
can be downladed here.