Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added color gradient in p5.Color.js file #7387

Closed
wants to merge 5 commits into from

Conversation

NalinDalal
Copy link

Resolves #7313

Changes:
Added the gradient field in the colour

Screenshots of the change:

PR Checklist

Copy link

welcome bot commented Nov 22, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@NalinDalal
Copy link
Author

please do this, i want to work more here as exams are over

@NalinDalal
Copy link
Author

either accept or reject, but please don't leave on seen man

@limzykenneth
Copy link
Member

Hi @NalinDalal, thanks for your patience. We are currently focusing mainly on p5.js 2.0 implementation which has a different internal implementation of p5.Color (as mentioned in the original issue). In the future it would be greatly appreciated if you can wait until a maintainer has reviewed the issue as needing implementation before filing a PR because otherwise we cannot confirm that the PR will be accepted. It is much better to work out any potential implementation in the issue first before a PR and we can better track your work.

@NalinDalal
Copy link
Author

where do i find p5.js 2.0 to solve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gradients for Fill and Strokes
2 participants