Fix transition_latent_value bug by using base_relation->nearest on latent_value_candidates #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyfertig
approved these changes
Oct 3, 2024
cxx/clean_relation.hh
Outdated
| @@ -518,6 +518,17 @@ class CleanRelation : public Relation<T> { | |||
| } | |||
| } | |||
|
|
|||
| ValueType nearest(const ValueType& x, const T_items& items, std::mt19937* prng) const { | |||
There was a problem hiding this comment.
For new methods we've been using the convention of prng first
emilyfertig
pushed a commit
that referenced
this pull request
Oct 4, 2024
Fix transition_latent_value bug by using base_relation->nearest on latent_value_candidates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.