Pass random seed from BayesDB PRNG into Crosscat. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires Crosscat version bump.
|
Test that crosscat meaningfully "received" the seed? Can you elaborate on what's still needed for the XXX? |
|
XXX comment says what's needed. Can you elaborate on what you're missing? |
|
I assume you're referring to the one in crosscat_seed? |
|
Re XXX: a fuller description of the current state, desired state, and e.g. where it's tracked (like an issue id). |
|
Sorry, I keep forgetting to specify. Whenever I ask for clarification on documentation, I don't mean in this history, I mean in the file itself, for others to read. |
|
Yes, I realize that -- I'm just trying to focus on Venture now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for probcomp/crosscat#92. Requires Crosscat dependency version bump.