-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sql-schema-connector): wasm-compatible sql-schema-connector
#5126
Conversation
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #5126 will not alter performanceComparing Summary
|
…postgresql" and "--features cockroachdb"
…mssql"; update mssql's quaint::visitor::Visitor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one thing I am worrying about is that we might end up with drift between the driver adapters and the native driver SqlFlavour, when I look at the existing SqlFlavour for native drivers it seems we should be able to re-use most of it (but not an issue yet)
This PR:
sql-schema-connector
schema-engine-cli
's functionality and the related tests (which use native Rust drivers) untouchedsqlite
featuremysql
featuremssql
featurepostgresql
featurecockroachdb
featurecore
sql_schema_connector::flavour::SqlFlavour
trait forquaint::connector::ExternalConnector
wrappers:sqlite
: ORM-505postgresql
+cockroachdb
: ORM-506