Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bun infinite loop #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: bun infinite loop #84

wants to merge 1 commit into from

Conversation

Heyter
Copy link

@Heyter Heyter commented Jan 14, 2025

#72

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-prisma ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 4:21am

@Heyter Heyter changed the title fix: bun infinity loop fix: bun infinite loop Jan 14, 2025
@Kuuzoo
Copy link
Contributor

Kuuzoo commented Jan 19, 2025

Hi @Heyter, thank you for trying to resolve the issue's with bun too.
@Dobefu and I already made some big improvements all over this module and already have PR #79 open waiting to be merged. It also includes a fix for the issue you are referring too, we just forgot to explicitly mention the issues it resolves in the description.

Still, I want to give you my feedback on your commit:
tryResolveModule is a function that is planned to be used internally inside of @nuxt/kit, so I'm unsure how smart it is, to use it from the outside?
Looking at the internal usage, they are always referring to the node_modules folder, but you are passing the project root. Is it working how you are using it right now?

@Kuuzoo
Copy link
Contributor

Kuuzoo commented Jan 22, 2025

Hi again @Heyter, v0.3.0 has been released 1 hour ago 😄
This does fix the infinit installation loop with bun!

Maybe you can give it a shot and then decide how to proceed with your PR 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants