Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused primer_react_css_modules_team feature flag #5670

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Feb 7, 2025

Merge after #5669 merges

Changelog

New

Changed

Removed

Removes the references to primer_react_css_modules_team feature flag because it's no longer in use.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why Test file and storybook variable updates

Merge checklist

@jonrohan jonrohan added the skip changeset This change does not need a changelog label Feb 7, 2025
Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: d957423

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.59 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 105.93 KB (-0.04% 🔽)

@jonrohan jonrohan marked this pull request as ready for review February 7, 2025 19:37
@jonrohan jonrohan requested a review from a team as a code owner February 7, 2025 19:37
@jonrohan jonrohan requested a review from joshblack February 7, 2025 19:37
Base automatically changed from css_modules_formcontrol_staff to main February 7, 2025 19:41
@jonrohan jonrohan added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 7ee5e2e Feb 7, 2025
51 checks passed
@jonrohan jonrohan deleted the remove_css_modules_team_flag branch February 7, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants