Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature-flag and extra @aat #5638

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Remove feature-flag and extra @aat #5638

merged 2 commits into from
Jan 31, 2025

Conversation

kendallgassner
Copy link
Contributor

@kendallgassner kendallgassner commented Jan 31, 2025 •
edited
Loading

I missed two comments on my previous PR (#5592):

This PR aims to fix them

Closes #

N/A

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@kendallgassner kendallgassner added the skip changeset This change does not need a changelog label Jan 31, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f855458

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.38 KB (0%)
packages/react/dist/browser.umd.js 105.83 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5638 January 31, 2025 19:53 Inactive
@kendallgassner kendallgassner changed the title [Draft] Remove feature-flag and extra @aat Remove feature-flag and extra @aat Jan 31, 2025
@kendallgassner kendallgassner marked this pull request as ready for review January 31, 2025 20:14
@kendallgassner kendallgassner requested a review from a team as a code owner January 31, 2025 20:14
@github-actions github-actions bot requested a deployment to storybook-preview-5638 January 31, 2025 20:18 Abandoned
@kendallgassner kendallgassner requested a review from khiga8 January 31, 2025 20:37
khiga8
khiga8 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up here 💟

@kendallgassner kendallgassner added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit c9b0a72 Jan 31, 2025
45 checks passed
@kendallgassner kendallgassner deleted the kendallg/axe-follow-up branch January 31, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khiga8 khiga8 khiga8 approved these changes

@joshblack joshblack joshblack approved these changes

@camertron camertron Awaiting requested review from camertron camertron is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kendallgassner @joshblack @khiga8