Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Accessibility][Storybook] Add aria-labels to the multiple item progress bar + enforce aria-label in progressbar.item" #5612

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Jan 28, 2025

Reverts #5559 due to failing CI checks in gh/gh

Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 349fa87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jan 28, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 28, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5612 January 28, 2025 04:52 Inactive
Copy link
Contributor

github-actions bot commented Jan 28, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.43 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js 104.82 KB (-0.1% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/359596

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 28, 2025
@kendallgassner kendallgassner marked this pull request as ready for review January 28, 2025 18:48
@kendallgassner kendallgassner requested a review from a team as a code owner January 28, 2025 18:48
Copy link
Contributor

@kendallgassner kendallgassner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree lets revert until I can fix the intergration failures! Apologies for the issues

@francinelucca francinelucca changed the title TEST Revert "[Accessibility][Storybook] Add aria-labels to the multiple item progress bar + enforce aria-label in progressbar.item" Revert "[Accessibility][Storybook] Add aria-labels to the multiple item progress bar + enforce aria-label in progressbar.item" Jan 29, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jan 29, 2025
@francinelucca francinelucca added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit a1122e4 Jan 29, 2025
47 checks passed
@francinelucca francinelucca deleted the revert-5559-kendallg/progress-bar branch January 29, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants