Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce Pagination algorithm enhancements #5590

Conversation

hectahertz
Copy link
Contributor

Reverts #5560

The original cause of the failing tests was that changing aria-disabled with aria-hidden triggered the contrast rules.

Here we add aria-disabled back.

@hectahertz hectahertz requested review from a team as code owners January 23, 2025 15:39
@hectahertz hectahertz requested a review from langermank January 23, 2025 15:39
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 9955465

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 23, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@hectahertz hectahertz self-assigned this Jan 23, 2025
@francinelucca francinelucca changed the title Revert "Revert "Pagination algorithm enhancements"" Reintroduce Pagination algorithm enhancements Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.42 KB (-0.14% 🔽)
packages/react/dist/browser.umd.js 104.83 KB (-0.05% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5590 January 23, 2025 15:48 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 23, 2025
@hectahertz
Copy link
Contributor Author

@github-actions github-actions bot temporarily deployed to storybook-preview-5590 January 29, 2025 04:52 Inactive
@hectahertz hectahertz closed this Jan 30, 2025
@hectahertz hectahertz deleted the revert-5560-revert-5504-hectahertz/pagination-algorithm-enhancements branch January 30, 2025 15:36
@francinelucca francinelucca reopened this Jan 30, 2025
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/360135

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jan 30, 2025
@francinelucca francinelucca added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit d045ae4 Jan 30, 2025
44 checks passed
@primer primer bot mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants