Add landing page and upload vrt/aat reports to GitHub Pages

[hussam-i-am]

Changelog

New

Changed

• Moved VRT/AAT workflow jobs into their own files and out of ci.yml
• Converted VRT/AAT workflow jobs into reusable workflows that get run as part of the deploy_preview.yml
• Downloads VRT/AAT reports to reside next to storybook
• Adds deployments for each report

• Adds index page that links storybook and reports

• Example of PR with failing VRT tests: Fix deploy_preview.yml workflow #5523

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Workflow updates, nothing to roll out

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

⚠️ No Changeset found

Latest commit: cc826c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	104.18 KB (0%)
packages/react/dist/browser.umd.js	104.52 KB (0%)

[langermank]

This makes me so happy I could cry 😂 the days of downloading VRT reports are over!

I would wait to merge until someone from eng reviews, but from a user perspective I APPROVE

[joshblack]

Thanks so much for doing this! 🥳 Just left a question to get your take on it, curious to hear what you say 👀

[joshblack]

Just thinking out loud, would it be possible for the required jobs to stay in the ci workflow and then have deploy_preview's trigger be workflow_run? Then we could use that deploy_preview workflow to download artifacts from the CI workflow that we would like to host/deploy.

[hussam-i-am]

I can give that a try. I think I was initially trying to avoid deploy_preview from waiting for ci and parallelize the reports running to run but it probably won't have a significant impact of time. Also it would minimize the changes being made at this point.

[joshblack]

Also, super random, but do you happen to know what permissions we need to clean up old environments/deployments? 👀 I remember trying to look into this in the past but couldn't figure it out and was curious if you knew. This is starting to come up more once we started having two deployments per-PR and since we're not removing any of them our list of environments is getting very long 😅

[hussam-i-am]

Also, super random, but do you happen to know what permissions we need to clean up old environments/deployments? 👀 I remember trying to look into this in the past but couldn't figure it out and was curious if you knew. This is starting to come up more once we started having two deployments per-PR and since we're not removing any of them our list of environments is getting very long 😅

I looked at it briefly and came across https://github.com/strumwolf/delete-deployment-environment. I was thinking we could potentially run a workflow when I PR is closed/merged to delete the envs for that PR.

[hussam-i-am]

@joshblack It doesnt look like deploy_preview is being triggered after CI finishes running. Am I missing something?

[joshblack]

@hussam-i-am oh you're totally right, the event right now is pull_request but was just asking about workflow_run as the trigger, e.g.

name: Deploy Preview
on:
  workflow_run:
    workflows: [ci]
    types:
      - completed

[hussam-i-am]

Yeah I updated deploy_preview to use workflw_run instead of pull_request but movie thhings back into ci.yml. ci runs but deploy_preview is not being run when it completes.

[joshblack]

Ohhh, sorry @hussam-i-am! Totally misunderstood you, my bad 👍

I think workflow_* events will only run off of the workflow in main so we would need to merge it to see.

[joshblack]

For actions/download-artifact, would we need to pass along run-id to these in order to download from the CI workflow? My assumption is that these try to download from the current workflow but let me know if that's incorrect

[hussam-i-am]

That was also my assumption and they seem to be updating correctly on each run