Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay: Add accessible names to Overlay dialog examples #5186

Closed
wants to merge 3 commits into from

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Oct 29, 2024

Adds an accessible name (aria-label) to Overlay dialogs.

Dialogs are typically named based on the content it provides, adding labels to the dialogs in the stories help convey what the dialog is for initially to assistive technologies.

Changelog

New

  • Adds aria-label to Overlay dialog examples

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why - This is a storybook only change and doesn't change anything else.

Testing & Reviewing

Merge checklist

@TylerJDev TylerJDev requested a review from a team as a code owner October 29, 2024 13:08
@TylerJDev TylerJDev requested a review from camertron October 29, 2024 13:08
Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 90b2471

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Oct 29, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5186 October 29, 2024 13:10 Inactive
Copy link
Contributor

github-actions bot commented Oct 29, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 100.04 KB (0%)
packages/react/dist/browser.umd.js 100.35 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-5186 November 5, 2024 13:52 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/352659

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added the integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh label Nov 26, 2024
@TylerJDev
Copy link
Contributor Author

After looking at the conflicts, we don't need this change anymore as we've added it in another PR. Closing!

@TylerJDev TylerJDev closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants