-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay: Add accessible names to Overlay
dialog examples
#5186
Conversation
|
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/352659 |
🟢 golden-jobs completed with status |
After looking at the conflicts, we don't need this change anymore as we've added it in another PR. Closing! |
Adds an accessible name (
aria-label
) to Overlay dialogs.Dialogs are typically named based on the content it provides, adding labels to the dialogs in the stories help convey what the dialog is for initially to assistive technologies.
Changelog
New
aria-label
toOverlay
dialog examplesRollout strategy
Testing & Reviewing
Merge checklist