Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AvatarStack: Adds back empty space in AvatarStack #5181

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

TylerJDev
Copy link
Contributor

@TylerJDev TylerJDev commented Oct 28, 2024

Adds back empty space in AvatarStack, as some tests expect it. We can come back and remove it later once reliance in some Dotcom tests are gone.

Changelog

Changed

  • Adds back empty space in AvatarStack

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 3bcb2b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 28, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5181 October 28, 2024 13:29 Inactive
Copy link
Contributor

github-actions bot commented Oct 28, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.19 KB (-0.04% 🔽)
packages/react/dist/browser.umd.js 97.58 KB (+0.01% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/348983

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@TylerJDev TylerJDev added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit c9e68d2 Oct 28, 2024
47 of 48 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/add-back-space-avatarstack branch October 28, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants