Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RiverStoryScroll disabled bug on narrow viewports #918

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Feb 3, 2025

Summary

Fixes a bug where RiverStoryScroll wasn't respecting the disabled prop on narrow viewports.

🔗 New Storybook example

Closes #881

List of notable changes:

  • Prevent relevant styles from rendering when they shouldn't

What should reviewers focus on?

  • Review the new story

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After
Screen.Recording.2025-02-03.at.11.52.10.mov
Screen.Recording.2025-02-03.at.11.52.30.mov

Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: 1ab5f49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 3, 2025

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Feb 3, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah merged commit 65f7a92 into main Feb 7, 2025
17 checks passed
@rezrah rezrah deleted the rezrah/river-story-scroll-disable-bug branch February 7, 2025 13:52
@primer-css primer-css mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Issues with River Story Scroll on mobile breakpoint
2 participants