Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase and standardize button group gap #909

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

danielguillan
Copy link
Contributor

@danielguillan danielguillan commented Jan 28, 2025

Summary

Closes #903

Increase the column gap between buttons in ButtonGroup (used by CTABanner) and Hero components to 16px and standardize row (16px) and column (8px) gaps.

Storybook examples:

Screenshots:

Before After

image

image

image

image

image

image

Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 66a18b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielguillan danielguillan marked this pull request as draft January 28, 2025 09:56
Copy link
Contributor

github-actions bot commented Jan 28, 2025

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Jan 28, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what's changed in this snapshot @danielguillan? Looks like size of image decreased. Could it be the button gap that's in the menu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the updated button gap in the Hero section at the top of the page, under the search overlay.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So confused why these border radius values weren't updated before. We should have received VRT warnings about them 🤔

Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Dani. Just some minor feedback, and some questions about the VRT but we might be able to resolve those in a follow up 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Increase spacing between CTA buttons
2 participants