-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase and standardize button group gap #909
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 66a18b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea what's changed in this snapshot @danielguillan? Looks like size of image decreased. Could it be the button gap that's in the menu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the updated button gap in the Hero section at the top of the page, under the search overlay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So confused why these border radius values weren't updated before. We should have received VRT warnings about them 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Dani. Just some minor feedback, and some questions about the VRT but we might be able to resolve those in a follow up 🤞
Co-authored-by: Rez <[email protected]>
Summary
Closes #903
Increase the column gap between buttons in
ButtonGroup
(used byCTABanner
) andHero
components to16px
and standardize row (16px
) and column (8px
) gaps.Storybook examples:
Screenshots: