Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLATFORM-1437]: Fix release #87

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

cpiemontese
Copy link
Contributor

@cpiemontese cpiemontese requested a review from a team as a code owner December 22, 2023 09:45
Copy link
Contributor

@cottinisimone cottinisimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn i forgot to fix this.. Anyway i think you need to change the release task in Makefile.toml in order to let this work. It should be:

[tasks.release]
description = "Task to release the package to crates.io"
command = "cargo"
args = ["publish", "--no-verify"]

Copy link
Contributor

@cottinisimone cottinisimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok :)

@cpiemontese cpiemontese merged commit dce2ab4 into master Dec 22, 2023
7 checks passed
@cpiemontese cpiemontese deleted the PLATFORM-1437/task/fix-release branch December 22, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants