-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the suggestions of https://github.com/pridiltal/staplr/pull/53#i… #54
base: master
Are you sure you want to change the base?
Conversation
@pridiltal , I made the requested changes. It might be interesting for you to run |
Hi @pridiltal , I created a new logo suggestion and it includes the code for automatic logo generation that is in |
What this pull request does is: 1 - Implement the changes suggested in #53 ; |
@pridiltal ,What this pull request does is: 1 - Implement the changes suggested in #53 ; Best regards. |
Hi @pridiltal , any position on this pull request? Best regards. |
Thank you very much @prdm0 for this pull request!. This new sticker looks great!! However, our already existing hex sticker for the package is already on the UseR hex wall https://twitter.com/pridiltal/status/1017225209688944641. If possible could you please re-PR the staple_pages so that I can merge it directly without going for cherry pick |
Hi @pridiltal , thanks for your reply. I think it's okay to have an old version of the sticker on UseR. Many packages like R Markdown and dplyr, for example, are changing their hex to more attractive versions. People will know that this is an evolution of the old hex. But if you still don't want the change, that's fine. I will soon be able to submit a pull request with changes #53 . Best regards. |
…lds) to export(identify_form_fields)
…ssuecomment-920510892.