-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve resolver performance #623
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
aee153d
feat: add custom metadata to the UserComponent that can be brought in…
Traveller23 2dac24c
chore: add changeset
Traveller23 6c4eb97
chore: change the level of the current changeset to patch
Traveller23 2299c1b
Merge branch 'prevwong:main' into main
Traveller23 df0bd8d
refactor: change UserComponentConfig.customMetadata to UserComponentC…
Traveller23 61af93f
Merge branch 'prevwong:main' into main
Traveller23 fd99f4f
fix: resolve performance issue within resolveComponent
Traveller23 aaac330
refactor: optimize the logic of resolveComponent()
Traveller23 fea783c
refactor(resolver): remove the logic for checking the existence of a …
Traveller23 722ab3b
Update fluffy-days-act.md
prevwong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@craftjs/core': minor | ||
--- | ||
|
||
Resolve performance issue within resolveComponent. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can remove Line 41-44.
I think if the component doesn't exists in the reversed resolver, then we can assume that the component doesn't exist.
Even if the component's name/display name exist in the resolver, it might still belong to a different component, so this may lead to bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, I'll remove those lines now.