-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow component metadata storage #578
Conversation
🦋 Changeset detectedLatest commit: df0bd8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We can already achieve the same results with the const Component = () => {}
Component.craft => {
custom: {...}
} |
There's a difference between Also, since we don't need to serialize |
Ah gotcha. Can we rename |
Sure, I'll change it right away. |
@prevwong Done. If any other changes need to be made, just let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! ❤️
UserComponent
that can be brought into Node
# Conflicts: # packages/core/src/interfaces/nodes.ts # packages/core/src/utils/createNode.ts
Related discussion: #576
After adding this feature, whenever we get the
Node
, we will also get the custom metadata of the user component. So we were able to automate some of the actions that we previously had to perform manually.This can bring more configurability to the whole framework.