Markdown pages #32
Open
Markdown pages #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had a temporary migration locally wich got set as the dependency
|
Thanks for proposing this, I'm sorry we never commented on #6 (which is very old and likely just forgotten about). I'm pretty sure we don't want to have two ways to create pages in this module in the long run. So if we would want to switch to Markdown (which is a big if for me and would require solving image upload and a few other things), we could talk about something like this as a migration path – but I don't see us supporting two ways going forward, that doesn't make much sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6
This PR adds a new field
content_type. in addition tohtml(which uses the existing rich text editor),markdowncan also be specified, which is then rendered accordingly.