start cleaning up blackout.c #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready for review |
adrienntindall
requested changes
Dec 16, 2023
src/blackout.c
Outdated
| static BOOL Task_ShowPrintedBlackoutMessage(TaskManager *taskManager) { | ||
| BlackoutScreenEnvironment *env = TaskManager_GetEnvironment(taskManager); | ||
| switch (env->state) { | ||
| case 0: |
There was a problem hiding this comment.
State enum consts if known
There was a problem hiding this comment.
not fully known, I am however debating whether this is the correct name for the func, as it does seem to mostly be palette fades
src/blackout.c
Outdated
| u16 deathSpawn; | ||
|
|
||
| switch (*state) { | ||
| case 0: |
There was a problem hiding this comment.
State consts if known
There was a problem hiding this comment.
not fully known, some are unclear
|
Address conflicting files please |
PikalaxALT
reviewed
Dec 17, 2023
| @@ -0,0 +1,243 @@ | |||
| #include "scrcmd.h" | |||
There was a problem hiding this comment.
Reviewing this file is made difficult by the fact that it was both renamed and substantially modified from field_black_out.c.
There was a problem hiding this comment.
that is somewhat the point
adrienntindall
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP