add vive controller support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! I don't have a Vive right now. Have you tried it out? |
|
@ngokevin I have some abstraction helpers which I decorate the oculus controls with (mainly so I could switch from left/right handed easily): https://github.com/presstube/norman/blob/master/js/oculustouchhelpers.js Looks like I'd have to rework those to consume the different events being produced by the Vive, unless I'm missing something? |
|
Didn't see those, thought it was just trigger. How can I set up locally? When I run the server I just get a Google sign in link that leads to a firebase error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey James! I think this might get Vive working. There shouldn't be much difference between Vive and Oculus support. We can attach both controller components, and they'll only be active once the respective controller is detected to be connected.