Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rediads bid adapter #5743

Merged
merged 18 commits into from
Dec 20, 2024
Merged

Rediads bid adapter #5743

merged 18 commits into from
Dec 20, 2024

Conversation

rediads
Copy link
Contributor

@rediads rediads commented Nov 30, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 9829fcb
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67656b46fa2468000874836b
😎 Deploy Preview https://deploy-preview-5743--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rediads
Copy link
Contributor Author

rediads commented Dec 9, 2024

Hello @ChrisHuie
Thank you for your suggestion! I've incorporated the additional fields from the Prebid documentation and expanded the code to include more detailed metadata, such as safeframes_ok, deals_supported, and floors_supported.

dev-docs/bidders/rediads.md Outdated Show resolved Hide resolved
@rediads
Copy link
Contributor Author

rediads commented Dec 12, 2024

@muuki88 Hello,

Thank you for bringing that to my attention. I have approved the changes and look forward to a successful merge.

@rediads rediads requested review from muuki88 and ChrisHuie December 12, 2024 13:32
@muuki88
Copy link
Contributor

muuki88 commented Dec 12, 2024

Hi @rediads

Awesome. Thanks for the quick fix. Once the prebid.js PR is released, we will merge the docs.

@rediads
Copy link
Contributor Author

rediads commented Dec 20, 2024

@muuki88 I hope you're doing well. The Prebid.js update has been merged and released. Could you kindly push the documentation live as well? Thank you!

@muuki88 muuki88 merged commit 8967858 into prebid:master Dec 20, 2024
5 checks passed
@muuki88
Copy link
Contributor

muuki88 commented Dec 20, 2024

Sure thing 🎄 happy holidays and a restful weekend ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants