Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: docereeadmanager.md #4975

Closed
wants to merge 12 commits into from
Closed

Conversation

Doceree-techStack
Copy link
Contributor

@Doceree-techStack Doceree-techStack commented Nov 9, 2023

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 2cd0741
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/660e602756266200095eebc3
😎 Deploy Preview https://deploy-preview-4975--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@muuki88
Copy link
Contributor

muuki88 commented Nov 9, 2023

@Doceree-techStack can you link the related pull request?

@Doceree-techStack
Copy link
Contributor Author

Related PR in prebid.js
prebid/Prebid.js#10684

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, but this is missing most of the metadata fields we need as documented in https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter . e.g. deals_supported, floors_supported, coppa_supported, etc.

Note that tcf2_supported was replaced by tcfeu_supported: please remove it.

Finally, publishers generally prefer that there be some contact info information in the bidder's docs. "In order to set up a Doceree account, please contact ____"

dev-docs/bidders/docereeadmanager.md Outdated Show resolved Hide resolved
gvl_id: 1063
tcf2_supported: true
tcfeu_supported: true
sidebarType: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more meta fields to ensure publishers can better vet your adapter

  • schain_supported: true/false
  • dchain_supported: true/false
  • userId: (list of supported vendors)
  • safeframes_ok: true/false
  • deals_supported: true/false
  • floors_supported: true/false
  • fpd_supported: true/false
  • pbs: true/false
  • prebid_member: true/false
  • ortb_blocking_supported: true/partial/false
  • privacy_sandbox: no or comma separated list of paapi, topics

see https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter for a full list

@bretg
Copy link
Contributor

bretg commented Mar 25, 2024

ping @Doceree-techStack

@bretg
Copy link
Contributor

bretg commented Apr 4, 2024

@Doceree-techStack - did you close this on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants