Kobler: New adapter (#3667) #3684
Open
+681
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
requested changes
Jan 24, 2025
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/KoblerConfiguration.java
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
Jan 30, 2025
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
| return Result.withErrors(errors); | ||
| } | ||
|
|
||
| modifiedRequest = modifiedRequest.toBuilder().imp(modifiedImps).build(); |
There was a problem hiding this comment.
please modify the request once
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
| return imp; | ||
| } | ||
|
|
||
| public boolean extractTestMode(Imp imp) { |
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
| try { | ||
| final ExtPrebid<?, ExtImpKobler> extPrebid = mapper.mapper().convertValue(imp.getExt(), | ||
| KOBLER_EXT_TYPE_REFERENCE); | ||
| final ExtImpKobler extImpKobler = extPrebid != null ? extPrebid.getBidder() : null; |
There was a problem hiding this comment.
parse the imp.ext in the same way you did before, please make it in the same style other bidders do
There was a problem hiding this comment.
I changed the code. My question is:
-Can we receive an empty ext in the request? If so, the parseImpExt method will return null. shuould I handle NPE? impExtKobler field is not rerequired.
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#3667