Metax: Update bidder (#3631) #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
398
to
403
| private static String givenBidResponse(Bid... bids) throws JsonProcessingException { | ||
| return mapper.writeValueAsString(BidResponse.builder() | ||
| .seatbid(singletonList(SeatBid.builder().bid(asList(bids)).build())) | ||
| .build()); | ||
| } | ||
|
|
There was a problem hiding this comment.
this one looks redundant
Comment on lines
411
to
413
| private static Bid givenBid(UnaryOperator<Bid.BidBuilder> bidCustomizer) { | ||
| return bidCustomizer.apply(Bid.builder()).build(); | ||
| } |
There was a problem hiding this comment.
this one is also redundant
AntoxaAntoxic
previously approved these changes
Jan 8, 2025
CTMBNara
requested changes
Jan 17, 2025
| .bidCurrency(bidResponse.getCur()) | ||
| .videoInfo(videoInfo(bid)) | ||
| .build()) | ||
|
|
There was a problem hiding this comment.
Please, remove empty line
There was a problem hiding this comment.
I also see a slight difference in logic with GO:
private String resolveEndpoint(ExtImpMetax extImpMetax) {
final String publisherIdAsString = Optional.ofNullable(extImpMetax.getPublisherId())
.map(Object::toString)
.orElse(StringUtils.EMPTY);
final String adUnitAsString = Optional.ofNullable(extImpMetax.getAdUnit())
.map(Object::toString)
.orElse(StringUtils.EMPTY);
In both cases we need to set the default value to "0" instead of "".
Please, fix this if you don't mind.
CTMBNara
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Add BidVideo for video ads
#3631