Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenX: Native support #3649

Merged
merged 19 commits into from
Jan 7, 2025
Merged

Conversation

sergseven
Copy link
Contributor

@sergseven sergseven commented Dec 23, 2024

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

OpenX starts to support native inventory, this change is aimed to add native bids support to the Prebid server java OpenX bidder adapter.

🧠 Rationale behind the change

We want to allow publishers to send native imp requests to OpenX through Prebid server java.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@sergseven sergseven changed the title EXCH-10878 Native support for OpenX bidder OpenX: Native support Dec 27, 2024
@sergseven sergseven marked this pull request as ready for review December 30, 2024 12:04
@sergseven
Copy link
Contributor Author

@AntoxaAntoxic thank you for the review
what's the next step to have it merged to the master?

@AntoxaAntoxic AntoxaAntoxic requested a review from CTMBNara January 7, 2025 12:55
@CTMBNara CTMBNara merged commit 2329a4d into prebid:master Jan 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants