Test: Transition PAAPI parameters
#3634
Open
+603
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
added
tests
|
Corresponding issue prebid/prebid-server#3536 |
osulzhenko
requested changes
Dec 26, 2024
src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/model/config/AccountAuctionConfig.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/model/request/auction/AuctionEnvironment.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/model/request/auction/ImpExt.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Outdated
Show resolved
Hide resolved
|
Required update |
…ests/transition-PAAPI-parameters
…transition-PAAPI-parameters
…ests/transition-PAAPI-parameters
…ests/transition-PAAPI-parameters
osulzhenko
requested changes
Jan 16, 2025
There was a problem hiding this comment.
we additionaly should verify:
- that aliases can request both original and iab formats.
- that if impId from configs and impId from the response are mismatched (including wildcards), nothing happens.
- that warnings are issued in debug mode, alert.general metrics are emitted.
- that interestGroupAuctionBuyer is ignored when provided by a bidder.
- that the server defaults to the original format if ext.prebid.paaformat is not set or is invalid.
- ensure that empty igs or igi arrays do not cause crashes or errors.
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Show resolved
Hide resolved
osulzhenko
requested changes
Jan 24, 2025
There was a problem hiding this comment.
we should also cover:
If there's no impid, then drop any igb objects from this entry. If any were dropped, mmit a warning in debug mode, log at N% sampling, and emit an alert.general metric.
and
Loop through the igb array
Add ext.bidder and ext.adapter to the igb entry
Add the igb entry to the global response entry
Rest is looking fine
| def auctionConfigs = response.ext?.prebid?.fledge?.auctionConfigs | ||
| assert auctionConfigs?.size() == 1 | ||
| assert auctionConfigs[0].impId == impId | ||
| assert auctionConfigs[0].bidder == bidResponse.seatbid[0].seat.value |
There was a problem hiding this comment.
Can we replace this with:
assert auctionConfigs[0].bidder == OPENX_ALIAS
Easier to identify :)
Comment on lines
+467
to
+468
| interestGroupAuctionSeller: [new InterestGroupAuctionSeller()], | ||
| interestGroupAuctionBuyer: [new InterestGroupAuctionBuyer()] |
There was a problem hiding this comment.
can we also add [] option?
| def interestGroupAuctionSeller = response.ext.interestGroupAuctionIntent[0].interestGroupAuctionSeller[0] | ||
| assert interestGroupAuctionSeller.impId == impId | ||
| assert interestGroupAuctionSeller.config == fledgeConfig | ||
| assert interestGroupAuctionSeller.ext.bidder == bidResponse.seatbid[0].seat.value |
There was a problem hiding this comment.
assert interestGroupAuctionSeller.ext.bidder == OPENX_ALIAS
| fledgeImpId << [PBSUtils.randomString, PBSUtils.randomNumber as String, WILDCARD.value] | ||
| } | ||
|
|
||
| def "PBS should log error and not populated fledge impId when bidder respond with empty config"() { |
There was a problem hiding this comment.
not an empty config, but an empty impid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check