Custom logger implementation on iOS #1026
Merged
+350
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will be making a docs PR after this is merged |
PrebidMobile/Logging/Log.swift
Outdated
| @@ -33,38 +33,70 @@ public class Log: NSObject { | |||
| public static var logToFile = false | |||
|
|
|||
| public static func error(_ object: Any, filename: String = #file, line: Int = #line, function: String = #function) { | |||
| log(object, logLevel: .error, filename: filename, line: line, function: function) | |||
| if (customLogger == nil) { | |||
There was a problem hiding this comment.
In my opinion, this kind of functionality should be implemented in the following way:
- Introduce the class
SDKConsoleLoggerwhich implementsPrebidLoggerprotocol - Introduce internal property
var logger: PrebidLogger? = SDKConsoleLogger() - Introduce a custom setter for the
loggerso pubs can set up own one. - in all functions of the
Logclass just uselogger?.dosomething( .... )
It will alow to avoid if ... else and seamlessly add another SDK loggers like SDKFileLogger if needed.
PrebidMobile/Logging/Log.swift
Outdated
| public static var logLevel: LogLevel = .debug | ||
| public static var logToFile = false | ||
|
|
||
| public static func error(_ object: Any, filename: String = #file, line: Int = #line, function: String = #function) { | ||
| log(object, logLevel: .error, filename: filename, line: line, function: function) | ||
| logger?.error(object, filename: filename, line: line, function: function) | ||
| } | ||
|
|
||
| public static func info(_ object: Any, filename: String = #file, line: Int = #line, function: String = #function) { | ||
| log(object, logLevel: .info, filename: filename, line: line, function: function) |
There was a problem hiding this comment.
Now, you should remove system fogging from the Log class. Otherwise, the same messages will be logged twice.
There was a problem hiding this comment.
They shouldn't because the SDKConsoleLogger's log method doesn't post to the system log.
jsligh
force-pushed
the
1023-setcustomlogger-implementation-from-android-library-is-not-present-in-ios-library
branch
from
729d976 to
bb768f8
Compare
|
@ValentinPostindustria, could you please finalize this PR? |
OlenaPostindustria
force-pushed
the
1023-setcustomlogger-implementation-from-android-library-is-not-present-in-ios-library
branch
from
f534dcf to
0d602ae
Compare
OlenaPostindustria
changed the title
OlenaPostindustria
force-pushed
the
1023-setcustomlogger-implementation-from-android-library-is-not-present-in-ios-library
branch
from
bffef8e to
b58f46c
Compare
YuriyVelichkoPI
deleted the
1023-setcustomlogger-implementation-from-android-library-is-not-present-in-ios-library
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1023