Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(signals-react): Remove automatic entrypoint #638

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

JoviDeCroock
Copy link
Member

Resolves #637

This is a major change, we are removing the automatic entry-point due to React 19 incompatibilities. We have considered this entry-point deprecated ever since moving to the Babel integration.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 44ddf55
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6772de3a1fda16000801ed33
😎 Deploy Preview https://deploy-preview-638--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Size Change: -243 B (-0.29%)

Total Size: 83.1 kB

Filename Size Change
docs/dist/assets/client.********.js 46.1 kB -243 B (-0.52%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/bench.********.js 1.59 kB
docs/dist/assets/index.********.js 836 B
docs/dist/assets/jsxRuntime.module.********.js 284 B
docs/dist/assets/preact.module.********.js 4.03 kB
docs/dist/assets/signals-core.module.********.js 1.41 kB
docs/dist/assets/signals.module.********.js 2.16 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.24 kB
docs/dist/basic-********.js 243 B
docs/dist/demos-********.js 3.44 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.45 kB
packages/core/dist/signals-core.mjs 1.47 kB
packages/preact/dist/signals.js 1.46 kB
packages/preact/dist/signals.mjs 1.43 kB
packages/react-transform/dist/signals-*********.js 4.93 kB
packages/react-transform/dist/signals-transform.mjs 4.16 kB
packages/react-transform/dist/signals-transform.umd.js 5.04 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 8c72dff into main Dec 31, 2024
6 checks passed
@JoviDeCroock JoviDeCroock deleted the remove-react-auto branch December 31, 2024 08:01
@github-actions github-actions bot mentioned this pull request Dec 31, 2024
Artur- added a commit to vaadin/hilla that referenced this pull request Jan 1, 2025
Artur- added a commit to vaadin/hilla that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing react signals in a node script fails with React 19
3 participants