Don't try to intercept links inside contenteditable

preactjs · Jul 29, 2024 · 374deb6 · 374deb6
1 parent ee0ba49
commit 374deb6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -117,7 +117,7 @@ function delegateLinkHandler(e) {
 
 	let t = e.target;
 	do {
-		if (t.localName === 'a' && t.getAttribute('href')) {
+		if (t.localName === 'a' && t.getAttribute('href') && !t.isContentEditable) {
 			if (t.hasAttribute('data-native') || t.hasAttribute('native')) return;
 			// if link is handled by the router, prevent browser defaults
 			if (routeFromLink(t)) {

diff --git a/test/dom.test.js b/test/dom.test.js
@@ -118,6 +118,25 @@ describe('dom', () => {
 			expect(onChange).not.toHaveBeenCalled();
 			expect(location.href).toContain('#foo');
 		});
+
+		it('should not intercept links inside contenteditable', () => {
+			let onChange = jasmine.createSpy();
+			mount(
+				<div>
+					<div contenteditable>
+						<a href="#foo">foo</a>
+					</div>
+					<Router onChange={onChange}>
+						<div default />
+					</Router>
+				</div>
+			);
+			onChange.calls.reset();
+			act(() => {
+				$('a').click();
+			});
+			expect(onChange).not.toHaveBeenCalled();
+		});
 	});
 
 	describe('Router', () => {