Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract render-html-plugin #855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/cli-util/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
const { blue, yellow, red } = require("kleur");
const { normalize } = require("path");
const { statSync, existsSync } = require("fs");
const symbols = require("./symbols");
const which = require("which");

exports.isDir = function(str) {
return existsSync(str) && statSync(str).isDirectory();
};

exports.hasCommand = function(str) {
return !!which.sync(str, { nothrow: true });
};

exports.trim = function(str) {
return str.trim().replace(/^\t+/gm, "");
};

exports.info = function(text, code) {
process.stderr.write(symbols.info + blue(" INFO ") + text + "\n");
code && process.exit(code);
};

exports.warn = function(text, code) {
process.stdout.write(symbols.warning + yellow(" WARN ") + text + "\n");
code && process.exit(code);
};

exports.error = function(text, code) {
process.stderr.write(symbols.error + red(" ERROR ") + text + "\n");
code && process.exit(code);
};

exports.normalizePath = function(str) {
return normalize(str).replace(/\\/g, "/");
};
19 changes: 19 additions & 0 deletions packages/cli-util/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"name": "@preact/cli-util",
"version": "3.0.0-rc.5",
"description": "Preact-cli's util library",
"main": "index.js",
"files": [
"*.js"
],
"engines": {
"node": ">=6"
},
"dependencies": {
"kleur": "^3.0.3",
"which": "^1.2.14"
},
"peerDependencies": {
"preact": "^8.1.0"
}
}
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/cli/lib/commands/build.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const rimraf = require('rimraf');
const { resolve } = require('path');
const { promisify } = require('util');
const { isDir, error, warn } = require('../util');
const { isDir, error, warn } = require('@preact/cli-util');
const runWebpack = require('../lib/webpack/run-webpack');

const toBool = val => val === void 0 || (val === 'false' ? false : val);
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/commands/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const { green } = require('kleur');
const { resolve, join } = require('path');
const { prompt } = require('prompts');
const isValidName = require('validate-npm-package-name');
const { info, isDir, hasCommand, error, trim, warn } = require('../util');
const { info, isDir, hasCommand, error, trim, warn } = require('@preact/cli-util');
const { addScripts, install, initGit, isMissing } = require('../lib/setup');

const ORG = 'preactjs-templates';
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/commands/list.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const fetch = require('isomorphic-unfetch');
const { bold, magenta } = require('kleur');
const { error, info } = require('../util');
const { error, info } = require('@preact/cli-util');

const REPOS_URL = 'https://api.github.com/users/preactjs-templates/repos';

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/commands/watch.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const runWebpack = require('../lib/webpack/run-webpack');
const { warn } = require('../util');
const { warn } = require('@preact/cli-util');

module.exports = async function(src, argv) {
argv.src = src || argv.src;
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const envinfo = require('envinfo');
const sade = require('sade');
const notifier = require('update-notifier');
const { error } = require('./util');
const { error } = require('@preact/cli-util');
const pkg = require('../package');

const ver = process.version;
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/lib/setup.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const spawn = require('cross-spawn-promise');
const { hasCommand, warn } = require('../util');
const { hasCommand, warn } = require('@preact/cli-util');

const stdio = 'ignore';

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/lib/webpack/push-manifest.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const createLoadManifest = require('./create-load-manifest');
const createLoadManifest = require('@preact/cli-util/webpack/create-load-manifest');

module.exports = class PushManifestPlugin {
constructor(env = {}) {
Expand Down
106 changes: 0 additions & 106 deletions packages/cli/lib/lib/webpack/render-html-plugin.js

This file was deleted.

2 changes: 1 addition & 1 deletion packages/cli/lib/lib/webpack/run-webpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const DevServer = require('webpack-dev-server');
const clientConfig = require('./webpack-client-config');
const serverConfig = require('./webpack-server-config');
const transformConfig = require('./transform-config');
const { error, isDir, warn } = require('../../util');
const { error, isDir, warn } = require('@preact/cli-util');

async function devBuild(env) {
let config = await clientConfig(env);
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/lib/webpack/sw-plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const BabelEsmPlugin = require('babel-esm-plugin');
const { DefinePlugin } = require('webpack');
const fs = require('fs');
const { resolve } = require('path');
const { info } = require('../../util');
const { info } = require('@preact/cli-util');
class SWBuilderPlugin {
constructor(config) {
const { src, brotli, esm } = config;
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/lib/webpack/transform-config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const { resolve } = require('path');
const webpack = require('webpack');
const fs = require('../../fs');
const { error } = require('../../util');
const { error } = require('@preact/cli-util');

const FILE = 'preact.config';
const EXTENSIONS = ['js', 'json'];
Expand Down
6 changes: 3 additions & 3 deletions packages/cli/lib/lib/webpack/webpack-client-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ const TerserPlugin = require('terser-webpack-plugin');
const OptimizeCssAssetsPlugin = require('optimize-css-assets-webpack-plugin');
const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
const CrittersPlugin = require('critters-webpack-plugin');
const renderHTMLPlugin = require('./render-html-plugin');
const renderHTMLPlugin = require('@preact/render-html-plugin');
const PushManifestPlugin = require('./push-manifest');
const baseConfig = require('./webpack-base-config');
const BabelEsmPlugin = require('babel-esm-plugin');
const { InjectManifest } = require('workbox-webpack-plugin');
const CompressionPlugin = require('compression-webpack-plugin');
const { normalizePath } = require('../../util');
const { normalizePath } = require('@preact/cli-util');
const SWBuilderPlugin = require('./sw-plugin');

const cleanFilename = name =>
Expand Down Expand Up @@ -86,7 +86,7 @@ async function clientConfig(env) {

plugins: [
new PushManifestPlugin(env),
...(await renderHTMLPlugin(env)),
...(await renderHTMLPlugin({})(env)),
...getBabelEsmPlugin(env),
new CopyWebpackPlugin(
[
Expand Down
36 changes: 0 additions & 36 deletions packages/cli/lib/util.js

This file was deleted.

7 changes: 3 additions & 4 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@
"@babel/preset-env": "^7.5.5",
"@babel/preset-typescript": "^7.3.3",
"@preact/async-loader": "^3.0.0-rc.0",
"@preact/cli-util": "^3.0.0-rc.5",
"@preact/render-html-plugin": "^3.0.0-rc.5",
"autoprefixer": "^9.6.0",
"babel-esm-plugin": "^0.5.0",
"babel-loader": "^8.0.6",
Expand All @@ -98,8 +100,6 @@
"get-port": "^5.0.0",
"gittar": "^0.1.0",
"glob": "^7.1.4",
"html-webpack-exclude-assets-plugin": "0.0.7",
"html-webpack-plugin": "^3.2.0",
"ip": "^1.1.5",
"isomorphic-unfetch": "^3.0.0",
"kleur": "^3.0.3",
Expand Down Expand Up @@ -133,8 +133,7 @@
"webpack-dev-server": "^3.4.1",
"webpack-fix-style-only-entries": "^0.3.0",
"webpack-merge": "^4.1.0",
"webpack-plugin-replace": "^1.2.0",
"which": "^1.2.14",
"webpack-plugin-replace": "^1.2.0",
"workbox-webpack-plugin": "^4.3.1"
}
}
Loading