Merge pull request #604 from praekeltfoundation/TBH-711-bug-copy-mism…

…atch-after-completing-screening Tbh 711 bug copy mismatch after completing screening
praekeltfoundation · Oct 10, 2023 · c19d86b · c19d86b
2 parents 9e135e7 + c103f05
commit c19d86b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/go-app-ussd_tb_check.js b/go-app-ussd_tb_check.js
@@ -980,7 +980,7 @@ go.app = function () {
           msisdn: msisdn,
           source: "USSD",
           language: answers.state_language,
-          province: answers.state_province ? answers.state_province : "",
+          province: answers.state_province ? answers.state_province : null,
           city: answers.state_city ? answers.state_city : "<not collected>",
           age: answers.state_age,
           gender: answers.state_gender,

diff --git a/src/ussd_tb_check.js b/src/ussd_tb_check.js
@@ -863,7 +863,7 @@ go.app = function () {
           msisdn: msisdn,
           source: "USSD",
           language: answers.state_language,
-          province: answers.state_province ? answers.state_province : "",
+          province: answers.state_province ? answers.state_province : null,
           city: answers.state_city ? answers.state_city : "<not collected>",
           age: answers.state_age,
           gender: answers.state_gender,

diff --git a/test/ussd_tb_check.test.js b/test/ussd_tb_check.test.js
@@ -2522,7 +2522,7 @@ describe("ussd_tb_check app", function () {
     });
   });
   describe("state_no_province", function () {
-    it("go to state_complete for valid answer and assign to blank for null province", function () {
+    it("go to state_complete for valid answer and assign to null for non province", function () {
       return tester.setup.user
         .state("state_opt_in")
         .setup.user.answers({
@@ -2547,7 +2547,7 @@ describe("ussd_tb_check app", function () {
                 msisdn: "+27123456789",
                 source: "USSD",
                 language: "eng",
-                province: "",
+                province: null,
                 city: "JHB",
                 age: "<18",
                 gender: "male",