[Flow decomposition][Reformat] Observer and NetworkUtil #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reformat observers in flow decompostion computer - Reformat NetworkUtil Signed-off-by: Hugo SCHINDLER <[email protected]>
5 tasks
Signed-off-by: Hugo SCHINDLER <[email protected]>
caioluke
reviewed
May 30, 2024
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/NetworkUtil.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/FlowDecompositionComputer.java
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/NetworkUtil.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/NetworkUtil.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/NetworkUtil.java
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/NetworkUtil.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/NetworkUtil.java
Show resolved
Hide resolved
…osses_compensation_improvement branch but it is friday night Signed-off-by: Hugo SCHINDLER <[email protected]>
|
I added a lot of test with some "golden master" tests |
|
…ecomposition_improvements # Conflicts: # flow-decomposition/src/main/java/com/powsybl/flow_decomposition/FlowDecompositionComputer.java # flow-decomposition/src/main/java/com/powsybl/flow_decomposition/FlowDecompositionResults.java # flow-decomposition/src/test/java/com/powsybl/flow_decomposition/TestUtils.java
Signed-off-by: Hugo SCHINDLER <[email protected]>
Signed-off-by: Hugo SCHINDLER <[email protected]>
|
Thank you for the review, I made some changes. Ready for review |
caioluke
approved these changes
Jun 3, 2024
flow-decomposition/src/main/java/com/powsybl/flow_decomposition/NetworkUtil.java
Outdated
Show resolved
Hide resolved
flow-decomposition/src/test/java/com/powsybl/flow_decomposition/TestUtils.java
Show resolved
Hide resolved
Signed-off-by: Hugo SCHINDLER <[email protected]>
|
Waiting for a final green light to merge this PR |
|
|
@OpenSuze it's all good for me! |
OpenSuze
added a commit
that referenced
this pull request
Jun 4, 2024
Signed-off-by: Hugo SCHINDLER <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
The goal is to remove terminal setP and setQ in losses compensation PR #147.
I used this PR to reformat observers in flow decompostion computer and the NetworkUtils functions.
What kind of change does this PR introduce?
Reformating
What is the current behavior?
No change
What is the new behavior (if this is a feature change)?
No change
Does this PR introduce a breaking change or deprecate an API?
Other information: