Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra check for invalid nodes #95

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cassandra check for invalid nodes #95

wants to merge 3 commits into from

Conversation

sylvlecl
Copy link
Contributor

@sylvlecl sylvlecl commented Jun 8, 2021

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

What is the new behavior (if this is a feature change)?

An "INVALID_NODES" check is added to cassandra implementation, to detect invalid rows in the nodes table.
By invalid row, we mean rows which contain null values where it should not, in particular in the name attribute.

sylvlecl added 2 commits June 8, 2021 09:17
Also, moving check logics to a separate class.

Signed-off-by: Sylvain Leclerc <[email protected]>
@sylvlecl sylvlecl requested a review from yichen88 June 8, 2021 13:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

82.3% 82.3% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants