fix(dispatcher): Fix pickle error on formula factory when using spawn method #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method When multiprocessing `spawn` method is used, serializing the formula factory method with pickle (on process spawn) fails and the following exception is raised : AttributeError: Can't pickle local object 'DispatcherActor._create_factory.<locals>.factory' This is due to the usage of a local function as formula factory, which pickle cannot serialize.
gfieni
force-pushed
the
fix/spawn-dispatcher-pickle-error
branch
from
88e42e3 to
f9b5807
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 67.63% 67.76% +0.12%
==========================================
Files 72 72
Lines 3297 3279 -18
==========================================
- Hits 2230 2222 -8
+ Misses 1067 1057 -10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a pickle error happening when the dispatcher actor is started using multiprocessing
spawnmethod.