refactor: Remove pylint pragma #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ny-nested-blocks check
This check prevent us to gracefully handle errors inside the actors.
…nd no-self-use checks
The `simple` modules have multiple problems: - They never should have been in the powerapi core. - Too much code for too little benefit compared to the actors tests. - Most of the tests needed specific behaviour that was too different from the base actor. Thus needing even more tests for the `simple` modules... - Because of the significant difference in the behaviour between real actors and the `simple` ones, the tests were not able to assess the performance of the actors pipeline, which was initially the main goal of the `simple` modules.
This allows to dynamically use fixtures without adding it to the parameter list and triggering a pylint warning about different arguments in the override of the method.
In Python 3.8, using type hint on generic types (`dict[str, str]`) instead of using the typing module (`Dict[str, str]`) will trigger the Pylint `unsubscriptable-object` error.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 66.93% 67.79% +0.86%
==========================================
Files 86 74 -12
Lines 3653 3413 -240
==========================================
- Hits 2445 2314 -131
+ Misses 1208 1099 -109
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Pylint pragma (
# pylint: disable=) usages across the codebase.