refactor: Fix CodeQL errors and warnings #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an Interface instead of Inheritance, and move the `cli_parser` attribute inside the classes because the types are too different. The SubgroupConfigParsingManager expects a SubgroupConfigParser, and RootConfigParsingManager expects a RootConfigParser. Even if both inherit from BaseConfigParser, their calling conventions differ too much, and it raises warnings in Pycharm and CodeQL.
gfieni
force-pushed
the
refactor/fix-codeql-warnings
branch
from
389789c to
acf4c76
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 66.67% 66.93% +0.25%
==========================================
Files 86 86
Lines 3655 3653 -2
==========================================
+ Hits 2437 2445 +8
+ Misses 1218 1208 -10
|
gfieni
force-pushed
the
refactor/fix-codeql-warnings
branch
from
acf4c76 to
389789c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all the errors and warnings raised by CodeQL.