Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown_stream() #23

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add markdown_stream() #23

wants to merge 2 commits into from

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Jan 30, 2025

In anticipation of posit-dev/py-shiny#1782, which adds ui.MarkdownStream() to Shiny for Python

  • 83c0f3d does a minimal change of just pulling in the new markdown-stream JS/CSS assets that the chat component will now depend upon.
  • 9f36cb0 takes a first pass at adding markdown_stream() and output_markdown_stream().

Open questions

  • Is shinychat a proper home for markdown_stream()?
  • Should it be output_markdown_stream() or markdown_stream_ui()?
    • The latter is more consistent with chat_ui() and also doesn't pretend be something it's not (an output)
  • How best to handle mid-stream errors? Show them in a notification? Should they crash the app?

TODO

@cpsievert cpsievert marked this pull request as draft January 30, 2025 16:16
Comment on lines +10 to +11
# TODO: Change this to main after this gets merged https://github.com/posit-dev/py-shiny/pull/1782
BRANCH=markdown-stream-component
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once posit-dev/py-shiny#1782 gets merged

Suggested change
# TODO: Change this to main after this gets merged https://github.com/posit-dev/py-shiny/pull/1782
BRANCH=markdown-stream-component
BRANCH=main

@cpsievert cpsievert changed the title Accomodate incoming markdown-stream web component from py-shiny Add markdown_stream() Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant